xintongsong commented on a change in pull request #11445: [FLINK-16615] Introduce data structures and utilities to calculate Job Manager memory components URL: https://github.com/apache/flink/pull/11445#discussion_r394808543
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerProcessSpec.java ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmanager; + +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.runtime.util.MemoryProcessUtils.MemoryProcessSpec; + +/** + * Describe the specifics of different resource dimensions of the JobManager process. + * + * <p>A JobManager's memory consists of the following components: + * <ul> + * <li>JVM Heap Memory</li> + * <li>Off-heap Memory</li> + * <li>JVM Metaspace</li> + * <li>JVM Overhead</li> + * </ul> + * We use Total Process Memory to refer to all the memory components, while Total Flink Memory refering to all + * the components except JVM Metaspace and JVM Overhead. + * + * <p>The relationships of JobManager memory components are shown below. + * <pre> + * ┌ ─ ─ Total Process Memory ─ ─ ┐ + * ┌ ─ ─ Total Flink Memory ─ ─ ┐ + * │ ┌───────────────────────────┐ │ + * On-Heap ----- ││ JVM Heap Memory ││ + * │ └───────────────────────────┘ │ + * │ ┌───────────────────────────┐ │ + * ┌─ ││ Off-heap Memory ││ + * │ │ └───────────────────────────┘ │ + * │ └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┘ + * │ │┌─────────────────────────────┐│ + * Off-Heap ─| │ JVM Metaspace │ + * │ │└─────────────────────────────┘│ + * │ ┌─────────────────────────────┐ + * └─ ││ JVM Overhead ││ + * └─────────────────────────────┘ + * └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┘ + * </pre> + */ +public class JobManagerProcessSpec implements MemoryProcessSpec { + private static final long serialVersionUID = -4141398426491608399L; + + private final MemorySize jvmHeapSize; + + private final MemorySize ofHeapMemorySize; + + private final MemorySize jvmMetaspaceSize; + + private final MemorySize jvmOverheadSize; + + JobManagerProcessSpec( + MemorySize jvmHeapSize, + MemorySize ofHeapMemorySize, Review comment: typo: offHeap ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
