pnowojski commented on a change in pull request #11347: 
[FLINK-14971][checkpointing] Make all the non-IO operations in 
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r395010728
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
 ##########
 @@ -342,6 +354,12 @@ public CheckpointException getFailureCause() {
 
                return finalizedLocationFuture.thenApplyAsync((completed) -> {
 
+                       if (isDiscarded()) {
+                               // since canceller has been already cancelled, 
the coordinator must be shut down
+                               // all the resources should be released 
properly when it's shutting down the coordinator
+                               throw new IllegalStateException("The checkpoint 
has been discarded");
+                       }
 
 Review comment:
   `checkState`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to