pnowojski commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r395004574
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -111,6 +108,14 @@
/** The executor for potentially blocking I/O operations, like state
disposal. */
private final Executor executor;
+ /** The executor for non-blocking operations. */
+ private final Executor mainThreadExecutor;
+
+ private final CompletedCheckpointStore completedCheckpointStore;
+
+ /** The lock for avoiding conflict between I/O operations. */
+ private final Object operationLock = new Object();
Review comment:
This is reverting a lock here. The issue is that we were able to make
`CheckpointCoordinator` code that's executed in the `mainThreadExecutor` lock
free, as `mainThreadExecutor` is single threaded. But we still need lock for IO
operations executed in the io executor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
