pnowojski commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r395017182
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -151,6 +149,9 @@
* It must be single-threaded. Eventually it will be replaced by main
thread executor. */
private final ScheduledExecutor timer;
+ @Nullable
+ private ComponentMainThreadExecutor mainThreadExecutor;
Review comment:
It's not nice that this is not a `final` field, but I guess this would need
large scope of changes, as there is the same issue in `ExecutionGraph`.
However, why does it have to be `@Nullable`?
`ExecutionGraph#jobMasterMainThreadExecutor` uses interesting trick with
`DummyComponentMainThreadExecutor`. I'm not sure if doing `instanceof` checks
is better or not, but maybe for the sake of consistency we should do the same
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
