pnowojski commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r395020929
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -311,25 +315,32 @@ public CheckpointException getFailureCause() {
try (CheckpointMetadataOutputStream out =
targetLocation.createMetadataOutputStream()) {
Checkpoints.storeCheckpointMetadata(savepoint, out);
finalizedLocation =
out.closeAndFinalizeCheckpoint();
+ }
+ CompletedCheckpoint completed = new
CompletedCheckpoint(
+ jobId,
+ checkpointId,
+ checkpointTimestamp,
+ System.currentTimeMillis(),
+ operatorStates,
+ masterStates,
+ props,
+ finalizedLocation);
+
+ try {
+
completedCheckpointStore.addCheckpoint(completed);
+ } catch (Throwable t) {
+ completed.discardOnFailedStoring();
Review comment:
I assume that one (or both) of the tests that you have added in the last
commit were failing before fixing the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
