zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r396211120
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -507,20 +510,27 @@ public boolean isFinished() {
private Optional<InputWithData<InputChannel, BufferAndAvailability>>
waitAndGetNextData(boolean blocking)
throws IOException, InterruptedException {
while (true) {
- Optional<InputChannel> inputChannel =
getChannel(blocking);
- if (!inputChannel.isPresent()) {
+ Optional<InputChannel> optionalInputChannel =
getChannel(blocking);
Review comment:
also irrelated changes, should revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
