zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397598985
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##########
@@ -140,14 +144,15 @@ else if (barrierId > currentCheckpointId) {
// abort the current checkpoint
releaseBlocksAndResetBarriers();
- checkpointAborted = true;
+
notifyCheckpointCompletedOrCanceled(currentCheckpointId);
// begin a new checkpoint
beginNewAlignment(barrierId, channelIndex,
receivedBarrier.getTimestamp());
}
else {
Review comment:
we can reduce this path for simple by
https://github.com/apache/flink/pull/11351/files#r397598435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services