zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397050537
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferConsumer.java
##########
@@ -44,6 +44,8 @@
private int currentReaderPosition;
+ private final boolean isExactlyOnceBarrier;
Review comment:
It seems a bit strange to see this field in `BufferConsumer`.
After discussing offline, we introduce another enum type for identifying the
specific `AbstractEvent` instance inside `Buffer` without deserialization. Then
the required components can judge the type from buffer to make some
improvements. At the beginning we only focus on `CheckpointBarrier` event and
make others unknown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
