zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397599479
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##########
@@ -214,7 +219,7 @@ protected void onBarrier(int channelIndex) throws
IOException {
}
@Override
- public boolean processCancellationBarrier(CancelCheckpointMarker
cancelBarrier) throws Exception {
+ public void processCancellationBarrier(CancelCheckpointMarker
cancelBarrier) throws Exception {
Review comment:
Refer to this idea
https://github.com/apache/flink/pull/11351/files#r397598435, we can also avoid
calling `notifyCheckpointCompletedOrCanceled` in five paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
