dianfu commented on a change in pull request #11448:
[FLINK-16666][python][table] Support new Python dependency configuration
options in flink-table.
URL: https://github.com/apache/flink/pull/11448#discussion_r404655850
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriverEnvUtils.java
##########
@@ -256,4 +328,17 @@ public static Process
startPythonProcess(PythonEnvironment pythonEnv, List<Strin
return process;
}
+
+ public static Process launchPy4jPythonClient(
Review comment:
The name is confusing as it actually starts up a Python process and the main
entrypoint of the Python process is one user's Python program instead of some
script provided by Py4j. So what about rename it to
prepareAndStartPythonProcess or revert this abstraction if we cannot come up
with a meaningful name? Besides, what about moving this method to PythonDriver?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
