dianfu commented on a change in pull request #11448:
[FLINK-16666][python][table] Support new Python dependency configuration
options in flink-table.
URL: https://github.com/apache/flink/pull/11448#discussion_r404662061
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriverEnvUtils.java
##########
@@ -54,17 +64,28 @@
private static final String FLINK_OPT_DIR_PYTHON = FLINK_OPT_DIR +
File.separator + "python";
- @VisibleForTesting
- public static final String PYFLINK_PY_FILES = "PYFLINK_PY_FILES";
+ private static final String FLINK_PYTHON_DIR = "flink-python";
- @VisibleForTesting
- public static final String PYFLINK_PY_REQUIREMENTS =
"PYFLINK_PY_REQUIREMENTS";
+ private static final String FLINK_PYTHON_LIB_DIR = "lib";
+
+ public static final String PYFLINK_CLIENT_EXECUTABLE =
"PYFLINK_CLIENT_EXECUTABLE";
@VisibleForTesting
- public static final String PYFLINK_PY_EXECUTABLE =
"PYFLINK_PY_EXECUTABLE";
+ static Configuration globalConf =
GlobalConfiguration.loadConfiguration();
@VisibleForTesting
- public static final String PYFLINK_PY_ARCHIVES = "PYFLINK_PY_ARCHIVES";
+ static Map<String, String> systemEnv = System.getenv();
Review comment:
private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
