zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r406701113
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -322,7 +341,7 @@ public int unsynchronizedGetNumberOfQueuedBuffers() {
public void flush() {
final boolean notifyDataAvailable;
synchronized (buffers) {
- if (buffers.isEmpty()) {
+ if (buffers.isEmpty() || readView == null ||
isBlockedByCheckpoint) {
Review comment:
I think we should not modify the condition of `flushRequested`, and only
work on the condition of `notifyDataAvailable`.
Then `isBlockedByCheckpoint` can be added into below `notifyDataAvailable`,
but now touch `readerView` condition which is out of scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
