zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r406816455
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -616,6 +622,11 @@ public void sendTaskEvent(TaskEvent event) throws
IOException {
}
}
+ @Override
+ public void unblockCheckpoint(int channelIndex) {
+ channelIndexToInputChannel[channelIndex].unblockCheckpoint();
Review comment:
`channelIndexToInputChannel` should be protected in sync by `requestLock`,
because in code path this array would be modified by RPC thread via
`updateInputChannel`. Although that method is never invoked in streaming job,
it still has the potential risk to break this assumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
