zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r406712652
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
##########
@@ -136,13 +136,13 @@ public void initializeState(ChannelStateReader
stateReader) throws IOException,
private final Buffer buffer;
private final boolean isMoreAvailable;
private final int buffersInBacklog;
- private final boolean nextBufferIsEvent;
+ private final boolean isAvailableWithoutCredit;
Review comment:
it is ambiguous to distinguish the semantics between
`isAvailableWithoutCredit` and `isMoreAvailable` if not back to see the
implementation. I prefer to using `dataAvailable` and `eventAvailable` instead.
And from the outside view, we only provide the `isAvailable(int credit)`
method for hiding the details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
