zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r406705401
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
##########
@@ -50,12 +50,14 @@
boolean isReleased();
+ void resumeConsumption();
+
Throwable getFailureCause();
/**
- * Returns whether the next buffer is an event or not.
+ * Returns true if we can read data without available credits.
*/
- boolean nextBufferIsEvent();
+ boolean isAvailableWithoutCredit();
Review comment:
it is better to merge `isAvailableWithoutCredit()` with existing
`isAvailable`() to avoid maintaining two separate interface methods. We can
integrate them into `isAvailable(int credit)` method for distinguishing the
condition inside implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
