zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r408743357
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferTest.java
##########
@@ -98,79 +98,79 @@ private static NetworkBuffer newBuffer(int length, int
maxCapacity, boolean isBu
@Test
public void testDataBufferIsBuffer() {
- assertFalse(newBuffer(1024, 1024, false).isBuffer());
+ assertFalse(newBuffer(1024, 1024,
Buffer.DataType.EVENT_BUFFER).isBuffer());
}
@Test
public void testEventBufferIsBuffer() {
- assertFalse(newBuffer(1024, 1024, false).isBuffer());
+ assertFalse(newBuffer(1024, 1024,
Buffer.DataType.EVENT_BUFFER).isBuffer());
}
@Test
public void testDataBufferTagAsEvent() {
- testTagAsEvent(true);
+ testTagAsEvent(Buffer.DataType.DATA_BUFFER);
}
@Test
public void testEventBufferTagAsEvent() {
- testTagAsEvent(false);
+ testTagAsEvent(Buffer.DataType.EVENT_BUFFER);
}
- private static void testTagAsEvent(boolean isBuffer) {
- NetworkBuffer buffer = newBuffer(1024, 1024, isBuffer);
- buffer.tagAsEvent();
+ private static void testTagAsEvent(Buffer.DataType dataType) {
+ NetworkBuffer buffer = newBuffer(1024, 1024, dataType);
+ buffer.setDataType(Buffer.DataType.EVENT_BUFFER);
assertFalse(buffer.isBuffer());
}
@Test
public void testDataBufferGetMemorySegment() {
- testGetMemorySegment(true);
+ testGetMemorySegment(Buffer.DataType.DATA_BUFFER);
}
@Test
public void testEventBufferGetMemorySegment() {
- testGetMemorySegment(false);
+ testGetMemorySegment(Buffer.DataType.EVENT_BUFFER);
}
- private static void testGetMemorySegment(boolean isBuffer) {
+ private static void testGetMemorySegment(Buffer.DataType dataType) {
final MemorySegment segment =
MemorySegmentFactory.allocateUnpooledSegment(1024);
- NetworkBuffer buffer = new NetworkBuffer(segment,
FreeingBufferRecycler.INSTANCE, isBuffer);
+ NetworkBuffer buffer = new NetworkBuffer(segment,
FreeingBufferRecycler.INSTANCE, dataType);
assertSame(segment, buffer.getMemorySegment());
}
@Test
public void testDataBufferGetRecycler() {
- testGetRecycler(true);
+ testGetRecycler(Buffer.DataType.DATA_BUFFER);
}
@Test
public void testEventBufferGetRecycler() {
- testGetRecycler(false);
+ testGetRecycler(Buffer.DataType.EVENT_BUFFER);
}
- private static void testGetRecycler(boolean isBuffer) {
+ private static void testGetRecycler(Buffer.DataType dataType) {
BufferRecycler recycler = MemorySegment::free;
- NetworkBuffer dataBuffer = newBuffer(1024, 1024, isBuffer,
recycler);
+ NetworkBuffer dataBuffer = newBuffer(1024, 1024, dataType,
recycler);
assertSame(recycler, dataBuffer.getRecycler());
}
@Test
public void testDataBufferRecycleBuffer() {
- testRecycleBuffer(true);
+ testRecycleBuffer(Buffer.DataType.DATA_BUFFER);
}
@Test
public void testEventBufferRecycleBuffer() {
- testRecycleBuffer(false);
+ testRecycleBuffer(Buffer.DataType.EVENT_BUFFER);
}
/**
* Tests that {@link NetworkBuffer#recycleBuffer()} and {@link
NetworkBuffer#isRecycled()} are
* coupled and are also consistent with {@link NetworkBuffer#refCnt()}.
*/
- private static void testRecycleBuffer(boolean isBuffer) {
- NetworkBuffer buffer = newBuffer(1024, 1024, isBuffer);
+ private static void testRecycleBuffer(Buffer.DataType dataType) {
+ NetworkBuffer buffer = newBuffer(1024, 1024, dataType);
Review comment:
nit: actually we can still retain `testRecycleBuffer(boolean isBuffer)`
method and get the respective `dataType` before `newBuffer` here. Then we can
avoid many above changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
