zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r408665333
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -396,13 +415,11 @@ public int getBuffersInBacklog() {
private boolean shouldNotifyDataAvailable() {
// Notify only when we added first finished buffer.
- return readView != null && !flushRequested &&
getNumberOfFinishedBuffers() == 1;
+ return readView != null && !flushRequested &&
!isBlockedByCheckpoint && getNumberOfFinishedBuffers() == 1;
}
private void notifyDataAvailable() {
- if (readView != null) {
Review comment:
Actually this condition even this method can be removed if we can reuse the
preceding three conditions inside `shouldNotifyDataAvailable` for `#flush()`
operation, because only the available conditions inside `#flush` not check the
`readerView != null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
