lirui-apache commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414570238
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -1403,4 +1446,29 @@ public CatalogColumnStatistics
getPartitionColumnStatistics(ObjectPath tablePath
}
}
+ private static boolean createObjectIsGeneric(Map<String, String>
properties) {
+ // When creating an object, a hive object needs explicitly have
a key is_generic = false
Review comment:
Sorry to hit the "resolve" button by mistake...
You're right but my point is we should differentiate whether we're creating
or getting an object here. E.g. `createObjectIsGeneric` should be used in
"create" methods like `createTable` or `createDatabase`, while
`getObjectIsGeneric` should be used in "get" methods like `getTable` or
`getDatabase`. It's clearer if the method names carry such information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
