lirui-apache commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r415030281
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -1403,4 +1446,29 @@ public CatalogColumnStatistics
getPartitionColumnStatistics(ObjectPath tablePath
}
}
+ private static boolean createObjectIsGeneric(Map<String, String>
properties) {
+ // When creating an object, a hive object needs explicitly have
a key is_generic = false
Review comment:
Having "create" or "get" in the method names are more friendly to the
method caller. The caller doesn't need to know whether the default value should
be true or false, or whether a default value should be appended if missing.
Instead, the caller just need to choose one method according to whether it's
creating or getting an object.
Perhaps we can name them as `isGenericForCreate` and `isGenericForGet`? So
that it's clear the method doesn't really `create` an object, but just to
decide whether an object is generic in different scenarios. Does that sound
better to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
