lirui-apache commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r415205960
##########
File path: flink-table/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<module>flink-table-uber-blink</module>
<module>flink-sql-client</module>
<module>flink-sql-parser</module>
+ <module>flink-sql-parser-hive</module>
Review comment:
A separate module makes things a little cleaner. Otherwise the pom file
of `sql-parser` will become messy and it can get even worse if we add more
dialects in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
