lirui-apache commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r415281739
##########
File path: flink-table/flink-table-planner-blink/pom.xml
##########
@@ -100,6 +100,18 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-sql-parser-hive</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
Review comment:
`flink-sql-parser` is a provided dep of `flink-sql-parser-hive`, which
means `flink-sql-parser` is not transitive. I suppose this can make the
dependencies clearer if we add a 3rd parser in the future. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]