zhuzhurk commented on a change in pull request #12375:
URL: https://github.com/apache/flink/pull/12375#discussion_r435198992
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -447,12 +452,40 @@ public void releaseSlot(@Nonnull SlotRequestId
slotRequestId, @Nullable Throwabl
componentMainThreadExecutor.assertRunningInMainThread();
+ checkState(batchSlotTimeoutCheckEnabled, "batch slot timeout
check is disabled unexpectedly.");
+
final PendingRequest pendingRequest =
PendingRequest.createBatchRequest(slotRequestId, resourceProfile);
return requestNewAllocatedSlotInternal(pendingRequest)
.thenApply(Function.identity());
}
+ @Override
+ public CompletableFuture<PhysicalSlot>
requestNewAllocatedSlotWithoutTimeout(
+ final SlotRequestId slotRequestId,
+ final ResourceProfile resourceProfile,
+ final boolean isBatchRequest) {
+
+ componentMainThreadExecutor.assertRunningInMainThread();
+
+ // a slot pool can serve either this kind of request or
requestNewAllocatedBatchSlot(...), never both
+ disableBatchSlotTimeoutCheck();
Review comment:
no more `requestNewAllocatedSlotWithoutTimeout()` anymore so no change
is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
