zhuzhurk commented on a change in pull request #12375:
URL: https://github.com/apache/flink/pull/12375#discussion_r435840523
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotProvider.java
##########
@@ -91,6 +92,20 @@
allocationTimeout);
}
+ /**
+ * Allocates a bulk of physical slots. The allocation will be completed
+ * normally only when all the requests are fulfilled.
+ *
+ * @param physicalSlotRequests requests for physical slots
+ * @param timeout indicating how long it is accepted that the slot
requests can be unfulfillable
+ * @return future of the results of slot requests
+ */
+ default CompletableFuture<Collection<PhysicalSlotRequest.Result>>
allocatePhysicalSlots(
Review comment:
Ok. It would be good to limit `OneSlotPerExecutionSlotAllocator` to only
use methods of the new interface.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotProvider.java
##########
@@ -91,6 +92,20 @@
allocationTimeout);
}
+ /**
+ * Allocates a bulk of physical slots. The allocation will be completed
+ * normally only when all the requests are fulfilled.
+ *
+ * @param physicalSlotRequests requests for physical slots
+ * @param timeout indicating how long it is accepted that the slot
requests can be unfulfillable
+ * @return future of the results of slot requests
+ */
+ default CompletableFuture<Collection<PhysicalSlotRequest.Result>>
allocatePhysicalSlots(
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
