zhuzhurk commented on a change in pull request #12375:
URL: https://github.com/apache/flink/pull/12375#discussion_r435199481
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -447,12 +452,40 @@ public void releaseSlot(@Nonnull SlotRequestId
slotRequestId, @Nullable Throwabl
componentMainThreadExecutor.assertRunningInMainThread();
+ checkState(batchSlotTimeoutCheckEnabled, "batch slot timeout
check is disabled unexpectedly.");
+
final PendingRequest pendingRequest =
PendingRequest.createBatchRequest(slotRequestId, resourceProfile);
return requestNewAllocatedSlotInternal(pendingRequest)
.thenApply(Function.identity());
}
+ @Override
+ public CompletableFuture<PhysicalSlot>
requestNewAllocatedSlotWithoutTimeout(
Review comment:
done via 9b5ca3d921855ddc3557d72202526cec6c474be8 and
54bd4613db64de1ff5b7fcdf29931a54895c3163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
