tzulitai commented on a change in pull request #127:
URL: https://github.com/apache/flink-statefun/pull/127#discussion_r448170589



##########
File path: docs/deployment-and-operations/packaging.md
##########
@@ -38,7 +38,7 @@ The provided base image allows teams to package their 
applications with all the
 Below is an example Dockerfile for building a Stateful Functions image with 
both an [embedded module]({{ site.baseurl }}/sdk/modules.html#embedded-module) 
and a [remote module]({{ site.baseurl }}/sdk/modules.html#remote-module) for an 
application called ``statefun-example``.
 
 {% highlight dockerfile %}
-FROM flink-statefun:{{ site.version }}
+FROM ververica/flink-statefun:{{ site.version }}

Review comment:
       I'd prefer not to change the base image mentioned here, as the 
`ververica/` hosted one is considered a temporary solution for the time being. 
We do mention the Ververica image as a side note below, so this should be fine?

##########
File path: docs/getting-started/python_walkthrough.md
##########
@@ -338,7 +338,7 @@ The base image provides the Stateful Function runtime, it 
will use the provided
 This can be found in the `Dockerfile` in the root directory. 
 
 {% highlight docker %}
-FROM flink-statefun:{{ site.version }}
+FROM ververica/flink-statefun:{{ site.version }}

Review comment:
       Same as comment above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to