XComp commented on a change in pull request #14132:
URL: https://github.com/apache/flink/pull/14132#discussion_r527697897
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParameters.java
##########
@@ -159,16 +160,16 @@ public boolean hasLog4j() {
@Override
public Optional<String> getLocalHadoopConfigurationDirectory() {
- final String[] possibleHadoopConfPaths = new String[] {
- System.getenv(Constants.ENV_HADOOP_CONF_DIR),
- System.getenv(Constants.ENV_HADOOP_HOME) +
"/etc/hadoop", // hadoop 2.2
- System.getenv(Constants.ENV_HADOOP_HOME) + "/conf"
- };
-
- for (String hadoopConfPath: possibleHadoopConfPaths) {
- if (StringUtils.isNotBlank(hadoopConfPath)) {
- return Optional.of(hadoopConfPath);
- }
+ final String hadoopConfDirEnv =
System.getenv(Constants.ENV_HADOOP_CONF_DIR);
+ final String hadoopHomeEnv =
System.getenv(Constants.ENV_HADOOP_HOME);
Review comment:
nit: We could move the variable initialization after the if block as its
not needed beforehand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
