tillrohrmann commented on a change in pull request #14132:
URL: https://github.com/apache/flink/pull/14132#discussion_r528723739
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParameters.java
##########
@@ -159,16 +160,16 @@ public boolean hasLog4j() {
@Override
public Optional<String> getLocalHadoopConfigurationDirectory() {
- final String[] possibleHadoopConfPaths = new String[] {
- System.getenv(Constants.ENV_HADOOP_CONF_DIR),
- System.getenv(Constants.ENV_HADOOP_HOME) +
"/etc/hadoop", // hadoop 2.2
- System.getenv(Constants.ENV_HADOOP_HOME) + "/conf"
Review comment:
Ah ok, so `System.getenv(Constants.ENV_HADOOP_HOME) + "/conf"` is only
relevant for Hadoop 1.x? In this case, I am fine with removing it since we no
longer test with Hadoop 1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
