wangyang0918 commented on a change in pull request #14132:
URL: https://github.com/apache/flink/pull/14132#discussion_r528448523
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParameters.java
##########
@@ -159,16 +160,16 @@ public boolean hasLog4j() {
@Override
public Optional<String> getLocalHadoopConfigurationDirectory() {
- final String[] possibleHadoopConfPaths = new String[] {
- System.getenv(Constants.ENV_HADOOP_CONF_DIR),
- System.getenv(Constants.ENV_HADOOP_HOME) +
"/etc/hadoop", // hadoop 2.2
- System.getenv(Constants.ENV_HADOOP_HOME) + "/conf"
Review comment:
At the very beginning, I think that we have two reasons to remove the
hadoop1 config directory here.
* It never works in the old code path since
`System.getenv(Constants.ENV_HADOOP_HOME) + "/etc/hadoop"` could not be null or
empty.
* Maybe we do not need to support Hadoop 1.x in Flink.
However, to improve the usability, I agree with you that there's no harm to
also support hadoop1 conf directory here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
