[
https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241065#comment-15241065
]
ASF GitHub Bot commented on FLINK-3750:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59709889
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,19 +90,34 @@ public void configure(Configuration parameters) {
* @throws IOException
*/
@Override
- public void open(InputSplit ignored) throws IOException {
+ public void open(InputSplit inputSplit) throws IOException {
try {
+ //TODO is this performed once per Task Manager..?
establishConnection();
statement = dbConn.createStatement(resultSetType,
resultSetConcurrency);
+ String query = queryTemplate;
+ if(isSplitConfigured()){
+ RangeInputSplit jdbcInputSplit =
(RangeInputSplit) inputSplit;
+ long start = jdbcInputSplit.getMin();
+ long end = jdbcInputSplit.getMax();
+ if(isSplitConfigured()){
+ query =
queryTemplate.replace(CONDITIONS, String.format(BETWEEN, splitColumnName,
start, end));
+ }
+ }
+ LOG.debug(query);
resultSet = statement.executeQuery(query);
} catch (SQLException se) {
- close();
+ //close(); already closed by the caller
throw new IllegalArgumentException("open() failed." +
se.getMessage(), se);
} catch (ClassNotFoundException cnfe) {
throw new IllegalArgumentException("JDBC-Class not
found. - " + cnfe.getMessage(), cnfe);
}
}
+ private boolean isSplitConfigured() {
+ return splitColumnName!=null;
--- End diff --
missing spaces around !=
> Make JDBCInputFormat a parallel source
> --------------------------------------
>
> Key: FLINK-3750
> URL: https://issues.apache.org/jira/browse/FLINK-3750
> Project: Flink
> Issue Type: Improvement
> Components: Batch
> Affects Versions: 1.0.1
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Priority: Minor
> Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism
> (NonParallelInput). I'd like to remove such limitation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
