[
https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241095#comment-15241095
]
ASF GitHub Bot commented on FLINK-3750:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59711855
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -241,10 +264,31 @@ private void addValue(OUT reuse) throws IOException,
SQLException {
reuse.setField(resultSet.getDouble(pos + 1), pos);
break;
case java.sql.Types.DECIMAL:
-
reuse.setField(resultSet.getBigDecimal(pos + 1).doubleValue(), pos);
- break;
+ //TODO manage null fields
+ try {
+ if (o == null){
+
reuse.setField("", pos);
+ } else{
+
reuse.setField(resultSet.getBigDecimal(pos + 1).toPlainString(), pos);
+ }
+ } catch (SQLException e) {
+
System.err.println("error reading at position " + pos + " setting blank
field!");
--- End diff --
this behavior is inconsistent with other types. either always fail or
always set a default value.
In any case, such an error should be logged.
> Make JDBCInputFormat a parallel source
> --------------------------------------
>
> Key: FLINK-3750
> URL: https://issues.apache.org/jira/browse/FLINK-3750
> Project: Flink
> Issue Type: Improvement
> Components: Batch
> Affects Versions: 1.0.1
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Priority: Minor
> Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism
> (NonParallelInput). I'd like to remove such limitation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
