[
https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241071#comment-15241071
]
ASF GitHub Bot commented on FLINK-3750:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59710345
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -363,14 +439,31 @@ public JDBCInputFormat finish() {
if (format.dbURL == null) {
throw new IllegalArgumentException("No database
URL supplied");
}
- if (format.query == null) {
+ if (format.queryTemplate == null) {
throw new IllegalArgumentException("No query
supplied");
}
if (format.drivername == null) {
throw new IllegalArgumentException("No driver
supplied");
}
+ adjustQueryTemplateIfNecessary();
return format;
}
+
+ /** Try to add $CONDITIONS token automatically (at least for
straightforward cases) */
+ private void adjustQueryTemplateIfNecessary() {
--- End diff --
we should simply fail if a user does not supply a Condition but wants to
use splits. This is murky territory imo,
> Make JDBCInputFormat a parallel source
> --------------------------------------
>
> Key: FLINK-3750
> URL: https://issues.apache.org/jira/browse/FLINK-3750
> Project: Flink
> Issue Type: Improvement
> Components: Batch
> Affects Versions: 1.0.1
> Reporter: Flavio Pompermaier
> Assignee: Flavio Pompermaier
> Priority: Minor
> Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism
> (NonParallelInput). I'd like to remove such limitation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
