[ 
https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241084#comment-15241084
 ] 

ASF GitHub Bot commented on FLINK-3750:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1885#discussion_r59711282
  
    --- Diff: 
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
 ---
    @@ -139,13 +163,10 @@ public void close() throws IOException {
        @Override
        public boolean reachedEnd() throws IOException {
                try {
    -                   if (resultSet.isLast()) {
    -                           close();
    -                           return true;
    -                   }
    -                   return false;
    +                   return !resultSet.next();
    --- End diff --
    
    this will skip records if reachedEnd is used multiple times in a row.


> Make JDBCInputFormat a parallel source
> --------------------------------------
>
>                 Key: FLINK-3750
>                 URL: https://issues.apache.org/jira/browse/FLINK-3750
>             Project: Flink
>          Issue Type: Improvement
>          Components: Batch
>    Affects Versions: 1.0.1
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>            Priority: Minor
>              Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism 
> (NonParallelInput). I'd like to remove such limitation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to