afedulov commented on a change in pull request #15054:
URL: https://github.com/apache/flink/pull/15054#discussion_r601421614



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java
##########
@@ -156,6 +156,48 @@
                     
.withDeprecatedKeys("jobmanager.web.backpressure.delay-between-samples")
                     .withDescription("This config option is no longer used");
 
+    /** Time, in milliseconds, after which cached stats are cleaned up if not 
accessed. */

Review comment:
       I understand the intent, but I think it might add some potential for 
confusion with respect to how the sampling is performed. Mainly because window 
semantics in Flink is based on time, whereas here it is about gathering a 
certain number of data points. Not sure it is fits.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to