afedulov commented on a change in pull request #15054:
URL: https://github.com/apache/flink/pull/15054#discussion_r602158828
##########
File path: flink-runtime-web/web-dashboard/package.json
##########
@@ -22,6 +22,8 @@
"@antv/g2": "^3.4.10",
"core-js": "^2.5.4",
"d3": "^5.9.1",
+ "d3-flame-graph": "^4.0.6",
Review comment:
This seems to be the accepted practice for node:
https://stackoverflow.com/a/44210813/336152 . I do not understand why the whole
file get's changed completely though in this case - I believe I've seen smaller
patches for it in the commit history, which would indicate that it was in fact
edited manually ¯\_(ツ)_/¯.
##########
File path: flink-runtime-web/web-dashboard/package.json
##########
@@ -22,6 +22,8 @@
"@antv/g2": "^3.4.10",
"core-js": "^2.5.4",
"d3": "^5.9.1",
+ "d3-flame-graph": "^4.0.6",
Review comment:
This seems to be the accepted practice for node:
https://stackoverflow.com/a/44210813/336152 . I do not understand why the whole
file get's changed completely though in this case - I believe I've seen smaller
patches for it in the commit history, which would indicate that it was in fact
edited manually ¯\_(ツ)_/¯.
##########
File path: flink-runtime-web/web-dashboard/package.json
##########
@@ -22,6 +22,8 @@
"@antv/g2": "^3.4.10",
"core-js": "^2.5.4",
"d3": "^5.9.1",
+ "d3-flame-graph": "^4.0.6",
Review comment:
This seems to be the accepted practice for node:
https://stackoverflow.com/a/44210813/336152 . I do not understand why the whole
file get's changed completely though in this case - I believe I've seen smaller
patches for it in the commit history, which would indicate that it was in fact
edited manually ¯\\_(ツ)_/¯.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
