afedulov commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r602417392
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/threadinfo/OperatorFlameGraphFactory.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.webmonitor.threadinfo; + +import org.apache.flink.runtime.messages.ThreadInfoSample; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** Factory class for creating Flame Graph representations. */ +public class OperatorFlameGraphFactory { + + /** + * Converts {@link OperatorThreadInfoStats} into a FlameGraph. + * + * @param sample Thread details sample containing stack traces. + * @return FlameGraph data structure + */ + public static OperatorFlameGraph createFullFlameGraphFrom(OperatorThreadInfoStats sample) { + Collection<Thread.State> included = Arrays.asList(Thread.State.values()); + return createFlameGraphFromSample(sample, included); + } + + /** + * Converts {@link OperatorThreadInfoStats} into a FlameGraph representing blocked (Off-CPU) + * threads. + * + * <p>Includes threads in states Thread.State.[TIMED_WAITING, Thread.State.BLOCKED, + * Thread.State.WAITING]. + * + * @param sample Thread details sample containing stack traces. + * @return FlameGraph data structure. + */ + public static OperatorFlameGraph createOffCpuFlameGraph(OperatorThreadInfoStats sample) { + Collection<Thread.State> included = + Arrays.asList( + Thread.State.TIMED_WAITING, Thread.State.BLOCKED, Thread.State.WAITING); + return createFlameGraphFromSample(sample, included); + } + + /** + * Converts {@link OperatorThreadInfoStats} into a FlameGraph representing actively running + * (On-CPU) threads. + * + * <p>Includes threads in states Thread.State.[TIMED_WAITING, Thread.State.BLOCKED, + * Thread.State.WAITING]. + * + * @param sample Thread details sample containing stack traces. + * @return FlameGraph data structure + */ + public static OperatorFlameGraph createOnCpuFlameGraph(OperatorThreadInfoStats sample) { + Collection<Thread.State> included = Arrays.asList(Thread.State.RUNNABLE, Thread.State.NEW); + return createFlameGraphFromSample(sample, included); + } + + private static OperatorFlameGraph createFlameGraphFromSample( + OperatorThreadInfoStats sample, Collection<Thread.State> threadStates) { + final NodeBuilder root = new NodeBuilder("root"); + for (List<ThreadInfoSample> threadInfoSubSamples : sample.getSamplesBySubtask().values()) { + for (ThreadInfoSample threadInfo : threadInfoSubSamples) { + if (threadStates.contains(threadInfo.getThreadState())) { + StackTraceElement[] traces = threadInfo.getStackTrace(); + root.increment(); + NodeBuilder parent = root; + for (int i = traces.length - 1; i >= 0; i--) { + final String name = + traces[i].getClassName() + + "." + + traces[i].getMethodName() + + ":" + + traces[i].getLineNumber(); + parent = parent.addChild(name); + } + } + } + } + return new OperatorFlameGraph(sample.getEndTime(), buildFlameGraph(root)); + } + + private static OperatorFlameGraph.Node buildFlameGraph(NodeBuilder builder) { + final List<OperatorFlameGraph.Node> children = new ArrayList<>(); Review comment: Looking at the graphs that I produced with my fraud detection sample application [1] it seems that the stack depth is around 20 typically. How about doubling it to account for some sophisticated user code calls? 40 would be my best guess. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-165%3A+Operator%27s+Flame+Graphs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
