afedulov commented on a change in pull request #15054:
URL: https://github.com/apache/flink/pull/15054#discussion_r602214774
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java
##########
@@ -156,6 +156,48 @@
.withDeprecatedKeys("jobmanager.web.backpressure.delay-between-samples")
.withDescription("This config option is no longer used");
+ /** Time, in milliseconds, after which cached stats are cleaned up if not
accessed. */
Review comment:
Yes, this approach is largely inspired by the previously existing
backpressure monitor which was also based on stack traces sampling. A couple of
pointers:
https://github.com/apache/flink/blob/c685251ce3b39362e45b07a12aa0cc6e7f665021/flin[…]re/src/main/java/org/apache/flink/configuration/WebOptions.java
https://github.com/apache/flink/blob/7e4694b8198664300b13b5304c62271b192d4512/flin[…]pache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java
https://github.com/apache/flink/blob/7e4694b8198664300b13b5304c62271b192d4512/flin[…]g/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
