zhuzhurk commented on a change in pull request #17:
URL: https://github.com/apache/flink-benchmarks/pull/17#discussion_r659465800
##########
File path:
src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkBase.java
##########
@@ -55,4 +58,10 @@ public static void runBenchmark(Class<?> clazz) throws
RunnerException {
new Runner(options).run();
}
+
+
+ @TearDown
+ public void teardown() {
+ SchedulerBenchmarkUtils.shutdownTestingUtilDefaultExecutor();
Review comment:
I agree with @pnowojski 's suggestion.
Maybe we can let all the scheduler benchmarks explicitly set the `executor`
when creating a Scheduler/ExecutionGraph. To be specific, the benchmarks can
extend a benchmark base which host an `executor` for Scheduler/ExecutionGraph
creation and provides a `shutDown()` method. All the benchmark executors in
`flink-benchmarks` should invoke the `shutDown()` when tearing down.
This also allows the benchmarks to get rid of the implicit assumption that
they relies on `TestingUtils.defaultExecutor()`, which may change in the future
and break this benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
