pnowojski commented on a change in pull request #17:
URL: https://github.com/apache/flink-benchmarks/pull/17#discussion_r659550273
##########
File path:
src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkBase.java
##########
@@ -55,4 +58,10 @@ public static void runBenchmark(Class<?> clazz) throws
RunnerException {
new Runner(options).run();
}
+
+
+ @TearDown
+ public void teardown() {
+ SchedulerBenchmarkUtils.shutdownTestingUtilDefaultExecutor();
Review comment:
Thanks for the explanation @Thesharing and +1 for what @zhuzhurk wrote.
Generally speaking, based on our previous experience, if benchmark is not
using public API it should be fully implemented in the `flink` repository,
while keeping `flink-benchmarks` as simple as possible for as much
compatibility as possible. For example having exposed across those two
repositories only very stable three methods: `#execute()`, `#setup()` (this one
optionally as builder if there are parameters), `#tearDown()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
