Thesharing opened a new pull request #17: URL: https://github.com/apache/flink-benchmarks/pull/17
In FLINK-22988, TestUtils are ported from Scala to Java. However, `SchedulerBenchmarkBase` in flink-benchmark calls this method when each benchmark teardowns. This make SchedulerBenchmarks not compiling, as FLINK-23078 says. To solve this issue, we'd like to wrap `TestingUtils.defaultExecutor().shutdownNow()` into `SchedulerBenchmarkUtil`. If this method is changed in the future, its reference must be fixed, too. Furthermore, it's confusing to have `SchedulerBenchmarkBase` in both flink and flink-benchmark. So I'd like to propose change `SchedulerBenchmarkBase` into `SchedulerBenchmarkExecutorBase` in flink-benchmark. ### Brief changelog * Change `TestingUtils.defaultExecutor().shutdownNow()` into `SchedulerBenchmarkUtil#shutdownTestingUtilDefaultExecutor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
