Thesharing commented on a change in pull request #17:
URL: https://github.com/apache/flink-benchmarks/pull/17#discussion_r659614433
##########
File path:
src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkBase.java
##########
@@ -55,4 +58,10 @@ public static void runBenchmark(Class<?> clazz) throws
RunnerException {
new Runner(options).run();
}
+
+
+ @TearDown
+ public void teardown() {
+ SchedulerBenchmarkUtils.shutdownTestingUtilDefaultExecutor();
Review comment:
Thank you for your suggestions, @zhuzhurk and @pnowojski. I came up with
a pull request: https://github.com/apache/flink/pull/16308. In this pull
request all the scheduler benchmarks inherit a base class. And in the base
class a `setup` and `teardown` method is added. The default executor is closed
in the `teardown` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
