fapaul commented on a change in pull request #16399:
URL: https://github.com/apache/flink/pull/16399#discussion_r665136421
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/sink/Sink.java
##########
@@ -93,6 +141,29 @@
/** @return The id of task where the writer is. */
int getSubtaskId();
+ /** @return number of parallel Sink tasks. */
+ int getNumberOfParallelSubtasks();
+
+ /** @return The metric group this writer belongs to. */
+ MetricGroup metricGroup();
+ }
+
+ /**
+ * The interface exposes some runtime info for creating a {@link
Committer} or {@link
+ * GlobalCommitter}.
+ */
+ interface CommitterInitContext {
Review comment:
I wonder whether we should only have one context to me there is no clear
difference between the `InitContext` and the `CommitterContext` i.e. to support
better-batching capabilities in the `CommiterContext` is probably also need
access to the `InitContext#getProcessingTimeService`.
I'd propose to keep everything in one context AFAIK it will be supplemented
by the exact same fields from the runtime context. WDYT? @AHeise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
