fapaul commented on a change in pull request #16399:
URL: https://github.com/apache/flink/pull/16399#discussion_r665224498
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java
##########
@@ -227,7 +231,36 @@ private int addCommitter(
Context context)
throws IOException {
- if (!sinkTransformation.getSink().createCommitter().isPresent()) {
+ if (!sinkTransformation
+ .getSink()
+ .createCommitter(
+ new Sink.CommitterInitContext() {
+ @Override
+ public MailboxExecutor getMailboxExecutor() {
+ return new MailboxExecutor() {
+ @Override
+ public void execute(
+ ThrowingRunnable<? extends
Exception> command,
+ String descriptionFormat,
+ Object... descriptionArgs) {}
+
+ @Override
+ public void yield()
+ throws InterruptedException,
FlinkRuntimeException {}
+
+ @Override
+ public boolean tryYield() throws
FlinkRuntimeException {
+ return false;
+ }
+ };
+ }
Review comment:
Can you explain these lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
