AHeise commented on a change in pull request #16399:
URL: https://github.com/apache/flink/pull/16399#discussion_r665208342



##########
File path: 
flink-core/src/main/java/org/apache/flink/api/connector/sink/Sink.java
##########
@@ -93,6 +141,29 @@
         /** @return The id of task where the writer is. */
         int getSubtaskId();
 
+        /** @return number of parallel Sink tasks. */
+        int getNumberOfParallelSubtasks();
+
+        /** @return The metric group this writer belongs to. */
+        MetricGroup metricGroup();
+    }
+
+    /**
+     * The interface exposes some runtime info for creating a {@link 
Committer} or {@link
+     * GlobalCommitter}.
+     */
+    interface CommitterInitContext {

Review comment:
       Mostly I wanted to avoid sharing `ProcessingTimeService` with 
committers. But maybe it's not a bad idea if you need to do some cleanup (hive 
small file compression?).
   
   For global committer, I'm unsure how `getSubtaskId` and 
`getNumberOfParallelSubtasks` are defined. But we could just statically set 0/1.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to