dawidwys commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763264549
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/PullingAsyncDataInput.java
##########
@@ -65,4 +66,13 @@
* point
*/
boolean hasReceivedEndOfData();
+
+ /**
+ * Tells if we should drain all results in case we received {@link
EndOfData} on all channels.
+ * If any of the upstream subtasks finished because of the
stop-with-savepoint --no-drain, we
+ * should not drain the current task. See also {@code StopMode}.
+ *
+ * <p>We should check the {@link #hasReceivedEndOfData()} first.
+ */
+ boolean shouldDrainOnEndOfData();
Review comment:
Yeah make sense. I even thought of it, but for some reason in the end I
decided against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
