dawidwys commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763705063
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java
##########
@@ -528,27 +490,6 @@ public void run(SourceContext<String> ctx) throws
Exception {
public void cancel() {}
}
- /** If finishing a task doesn't swallow exceptions this test would fail
with an exception. */
- @Test
- public void finishingIgnoresExceptions() throws Exception {
Review comment:
test removal explanation: I removed the `finishTask`. We also do not
swallow exceptions anymore. We assume the contract of `SourceFunction#cancel`
which is called when triggering a synchronous checkpoint, and expect the source
to finish gracefully. If it does not the exception is not swallowed, as it is a
user error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
