dawidwys commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763708144
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SynchronousCheckpointTest.java
##########
@@ -76,24 +75,6 @@ public void setupTestEnvironment() throws
InterruptedException {
assertThat(eventQueue.take(), is(Event.TASK_INITIALIZED));
}
- @Test(timeout = 20_000)
- public void
synchronousCheckpointBlocksUntilNotificationForCorrectCheckpointComes()
Review comment:
This depends on a shady `getSynchronousSavepointId` and is covered by
tests in `StreamTaskFinalCheckpointsTest`.
The reason why it does not work is that we do not clear the
`synchronousSavepointId` internally, because it is not necessary. Previously,
clearing the flag was used to exit the synchronous loop. Now, without a
synchronous loop, we simply exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
