dawidwys commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763713610
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceTaskTerminationTest.java
##########
@@ -118,9 +120,6 @@ private void stopWithSavepointStreamTaskTestHelper(final
boolean shouldTerminate
srcTaskTestHarness.processUntil(
srcTask.notifyCheckpointCompleteAsync(syncSavepointId)::isDone);
- if (!shouldTerminate) {
- assertFalse(srcTask.getSynchronousSavepointId().isPresent());
Review comment:
The thing is it is not cleaned up, as it does not need to. The reason it
was cleaned up was to break out of the synchronous mailbox loop. Without the
loop there is no point in cleaning it up. We will exit anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
