dawidwys commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763716735
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java
##########
@@ -577,45 +518,6 @@ public void testWaitsForSourceThreadOnCancel() throws
Exception {
harness.waitForTaskCompletion(Long.MAX_VALUE, true);
}
- @Test
- public void testStopWithSavepointShouldNotInterruptTheSource() throws
Exception {
Review comment:
This is the only test I considered rewriting. I have not found a good
way to do so though. First let me explain why it does not work with my changes.
The problem is the source needs to exit first in order for the sync
savepoint to complete (actually to even be triggered). Thus the
```
notifyFuture.get();
WasInterruptedTestingSource.allowExit();
```
hangs forever.
I don't think there is a good point now, where we can say: "ok, now we are
confident the source will no longer be interrupted". At the same time, I don't
think we loose much without the test. The corresponding code path is quite
simple. We simply call `StreamSource#stop` which we expect will shutdown the
source thread gracefully. Therefore I thought it should be safe to remove the
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
