rkhachatryan commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r768530277



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -135,7 +135,9 @@ public void triggerCheckpoint(long checkpointId) throws 
FlinkException {
                                             
CheckpointStorageLocationReference.getDefault(),
                                             
configuration.isExactlyOnceCheckpointMode(),
                                             
configuration.isUnalignedCheckpointsEnabled(),
-                                            
configuration.getAlignedCheckpointTimeout().toMillis());
+                                            
configuration.getAlignedCheckpointTimeout().toMillis(),
+                                            false /* TODO: we do not support 
no-claim mode with
+                                                  externally induced sources 
for now */);

Review comment:
       I see, thanks. I think it makes sense to reference that ticket in the 
code too.
   (I was only asking for reason, not proposing to actually add support).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to