dawidwys commented on a change in pull request #18086:
URL: https://github.com/apache/flink/pull/18086#discussion_r768543573
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -875,6 +890,21 @@ public JobExecutionResult executeJobBlocking(JobGraph job)
(Acknowledge ignored) -> new
JobSubmissionResult(jobGraph.getJobID()));
}
+ // HACK: temporary hack to make the randomized changelog state backend
tests work with forced
+ // full snapshots. This option should be removed once changelog state
backend supports forced
+ // full snapshots
+ private void checkRestoreModeForRandomizedChangelogStateBackend(JobGraph
jobGraph) {
+ final SavepointRestoreSettings savepointRestoreSettings =
+ jobGraph.getSavepointRestoreSettings();
+ if (overrideRestoreModeForRandomizedChangelogStateBackend
+ && savepointRestoreSettings.getRestoreMode() ==
RestoreMode.NO_CLAIM) {
+ final Configuration conf = new Configuration();
+ SavepointRestoreSettings.toConfiguration(savepointRestoreSettings,
conf);
+ conf.set(SavepointConfigOptions.RESTORE_MODE, RestoreMode.LEGACY);
Review comment:
The failing tests are all IT tests that randomly choose to use the
changelog state backend and do any kind of restore from a savepoint/checkpoint,
e.g. migration tests.
The reason is we use the `NO_CLAIM` by default in this PR and changelog
state backend does not `supportForcedFullSnapshots(ForcedReupload)`. Another
idea would be to switch the default for now to `RestoreMode#LEGACY` and switch
it to `NO_CLAIM` once we support it in changelog state backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
